#16241: New MOLS shared by Ian Wanless
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.2
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
Authors: | e59d6cbc55535cbc65d5cebc2169ff11603b2d74
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/16241 |
Dependencies: |
#16235 |
-------------------------+-------------------------------------------------
Comment (by vdelecroix):
Hi Nathann,
1) You forgot to add your functions in the head docstring.
2) Could you do appropriate doctests as in #16227? Especially check that
the constructor work for these values.
3) There is a typo or an error in `_MOLS_from_string`. The characters
belong to `a-z` and not `0-z`... but, in prevision of bigger constructions
it would be better to really start from `0` (which is `chr(48)`) and go up
to `z` (which is `chr(122)`).
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16241#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
