#16286: Allow k=None in MOLS/TD/OA
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: design, mols, | Merged in:
orthogonal array | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16286 | 4970da45741acac330b2602c967e5fed681fdfa3
Dependencies: #16272 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
Hi Nathann,
I run through the code and mainly changed some documentation. It is
available at u/vdelecroix/16286 if you want to have a look it and possibly
adopt it.
It becomes crazy: the functions return either a design , a troolean or an
integer depending on the input... I added an OUTPUT section to make it
clearer (only in OA/TD). Moreover I am not sure I like the NOTE inside the
INPUT. On the one hand, it is unreadable in the console. On the other
hand, in the html output the NOTE has a gray background and makes your
eyes focus on it... but it is by far not the most important thing.
We forgot two `ValueError` that should be `EmptySetError` inside the MOLS
constructor. I changed it.
Inside the TESTS of transversal design, you modified the loop to not test
the case where the function should return `True`. As the loop is designed
to '''test''' if it the case I did the change backward. Nevertheless, I
added a line that checks that we got the correct value when `k=None`.
I added more examples and hope that what does the function looks clearer
when somebody reads the documentation. In particular, most of the TESTS
section are now useless and I just removed them.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16286#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
