#6083: speedup integer division
------------------------------+---------------------------------------------
Reporter: robertwb | Owner: somebody
Type: defect | Status: new
Priority: major | Milestone:
Component: basic arithmetic | Keywords:
------------------------------+---------------------------------------------
Comment(by fredrik.johansson):
I now get one trivial test failure (changed exception message):
{{{
File "/home/fredrik/sage-4.0/devel/sage-mpmath/sage/rings/integer.pyx",
line 2163:
sage: z % 0
Expected:
Traceback (most recent call last):
...
ZeroDivisionError: Integer modulo by zero
Got:
Traceback (most recent call last):
File "/space/wstein/farm/sage-4.0/local/bin/ncadoctest.py", line
1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/space/wstein/farm/sage-4.0/local/bin/sagedoctest.py", line
38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/space/wstein/farm/sage-4.0/local/bin/ncadoctest.py", line
1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_46[4]>", line 1, in <module>
z % Integer(0)###line 2163:
sage: z % 0
File "integer.pyx", line 2189, in sage.rings.integer.Integer.__mod__
(sage/rings/integer.c:15033)
ZeroDivisionError: other must be nonzero
}}}
Otherwise, this patch has my approval.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6083#comment:1>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---