#6083: [with patch, with positive review modulo referee's patch] speedup integer
division
------------------------------+---------------------------------------------
Reporter: robertwb | Owner: somebody
Type: defect | Status: new
Priority: major | Milestone:
Component: basic arithmetic | Keywords:
------------------------------+---------------------------------------------
Comment(by craigcitro):
This patch looks good. I've added a referee patch that makes a few really
minor changes:
* removes the unused `_floordiv` function
* changes the error messages: they all now say either "Integer division
by zero" or "Integer modulo by zero." I think these are more informative,
and they also now mirror the Python ones (which all say "integer division
or modulus by zero"). The old ones were of the form `"other (=%s) must be
nonzero"%other`, and by definition '''always''' had other equal to 0, so
that just seemed silly.
Unless Robert or Fredrik has any objections to the second patch, I'd say
this is good to go.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6083#comment:3>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
