#16321: Improve caching for spaces of modular forms
-------------------------------------+-------------------------------------
Reporter: saraedum | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.3
Component: modular forms | Resolution:
Keywords: | Merged in:
Authors: Julian Rüth | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/saraedum/ticket/16321 | 6963cccfd8cd6812ae50477af5fbbf2cdcdb0321
Dependencies: #16328 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Julian R\xfcth', 'oldvalue': ''}):
* status: new => needs_review
* commit: => 6963cccfd8cd6812ae50477af5fbbf2cdcdb0321
* author: => Julian Rüth
Old description:
> Spaces of modular forms do manual caching which causes trouble at #11895.
> This ticket aims to cleanup the code to use `cached_method`, factories,
> and `UniqueRepresentation` where appropriate.
New description:
Spaces of modular forms do manual caching which causes trouble at #11895.
This ticket aims to cleanup the code to use `cached_method`, and
`UniqueRepresentation` where appropriate.
It also moves `HeckeModule` from `Module_old` to `Module`.
--
Comment:
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=88cab96529c0a4a8915a4a6c19d4918d30aac49a
88cab96]||{{{Replaced all manual caching in modular forms spaces with the
@cached_method decorator}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6a0ff9806aed625ae67205a982aee3c6cf3f0257
6a0ff98]||{{{Ambient spaces for modular forms have
CachedRepresentation}}}||
||[http://git.sagemath.org/sage.git/commit/?id=27404949f029a1f0eadb0a14ac5081c570572e03
2740494]||{{{Remove explicit caching from ModularForms()}}}||
||[http://git.sagemath.org/sage.git/commit/?id=3b99babd4e9d426fe414e39f12365477c9c12cbf
3b99bab]||{{{Set ModularFormSpace.Element}}}||
||[http://git.sagemath.org/sage.git/commit/?id=324bef389799080b91bb6f34672f09974f7a0064
324bef3]||{{{Added a category parameter to Module}}}||
||[http://git.sagemath.org/sage.git/commit/?id=ea6afa910eb6921e4e12628d5809603ad5f7cbe8
ea6afa9]||{{{Merge branch 'ticket/16328' into ticket/16321}}}||
||[http://git.sagemath.org/sage.git/commit/?id=aee72f7857f58ac34d691428f6010a2984fd420f
aee72f7]||{{{fixed a typo in category_object.pyx}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6963cccfd8cd6812ae50477af5fbbf2cdcdb0321
6963ccc]||{{{Turned HeckeModule from a Module_old into a Module}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16321#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.