#15153: Check embedding morphism when comparing two toric varieties
-------------------------------------+-------------------------------------
       Reporter:  jkeitel            |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.3
      Component:  algebraic          |   Resolution:
  geometry                           |    Merged in:
       Keywords:  toric              |    Reviewers:
        Authors:  Jan Keitel         |  Work issues:  clarify documentation
Report Upstream:  N/A                |       Commit:
         Branch:                     |  545f468f36ee3141dbc974821a0938061a87bad7
  u/jkeitel/toric_variety_cmp        |     Stopgaps:
   Dependencies:  #12892             |
-------------------------------------+-------------------------------------
Changes (by novoselt):

 * status:  needs_review => needs_work
 * work_issues:   => clarify documentation


Comment:

 There are multiple references to "the criteria of
 :class:`ToricEmbedding<ToricEmbedding_Mixin>`" yet upon looking into
 docstrings of that class these criteria are not clear. There are also
 tests where it seems that the same morphisms are constructed, yet they
 compare unequal. Would be nice to have a precise definition of what is
 considered an embedding morphism and why it is necessary to compare equal
 morphisms as unequal.

--
Ticket URL: <http://trac.sagemath.org/ticket/15153#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to