#14990: Implement algebraic closures of finite fields
-------------------------------------+-------------------------------------
       Reporter:  pbruin             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  algebra            |   Resolution:
       Keywords:  finite field       |    Merged in:
  algebraic closure                  |    Reviewers:
        Authors:  Peter Bruin        |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/pbruin/14990     |  63bc7aa3b23e6d7dc4db54de76c60b24134e7895
   Dependencies:  #14958, #13214     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Hi Peter,

 I agree with your analysis of (3).

 All test pass and the documentation builds.

 There is a typo which becomes ugly in the compiled documentation. At line
 960 of `algebraic_closure_finite_field.py` you wrote
 
{{{`:meth:~sage.rings.finite_rings.finite_field_base.FiniteField.algebraic_closure`}}}
 instead of
 
{{{:meth:`~sage.rings.finite_rings.finite_field_base.FiniteField.algebraic_closure`}}}.

 Once the change done, you can set to positive review.

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/14990#comment:88>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to