#16012: Sublattice fan isomorphism bug
----------------------------+------------------------
Reporter: novoselt | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-6.3
Component: geometry | Resolution:
Keywords: toric | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
----------------------------+------------------------
Comment (by jkeitel):
Hi Andrey,
there's a simple fix for that. Simply replace
{{{if self.lattice_dim() == 2:}}}
in {{{fan.py}}} by
{{{if self.lattice_dim() == 2 and self.lattice() is
self.lattice().ambient_module() and other.lattice() is
other.lattice().ambient_module()}}}
because the alternative method of trying to find an isomorphism still
works - it's just the echelon forms that 'know' about the sublattice and
therefore compare unequal. Alternatively, one could modify the
{{{fan_2d_echelon_form()}}} in {{{fan_isomorphism.py}}} such that it
removes empty rows.
What do you think?
--
Ticket URL: <http://trac.sagemath.org/ticket/16012#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
