#16012: Sublattice fan isomorphism bug
-------------------------------------+-------------------------------------
       Reporter:  novoselt           |        Owner:
           Type:  defect             |       Status:  new
       Priority:  major              |    Milestone:  sage-6.3
      Component:  geometry           |   Resolution:
       Keywords:  toric              |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jkeitel/sub_fan_isomorphism      |  656fa89b8d9ab818c31c4b631a011727f340ea92
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jkeitel):

 * commit:   => 656fa89b8d9ab818c31c4b631a011727f340ea92
 * branch:   => u/jkeitel/sub_fan_isomorphism


Comment:

 Okay, actually it might be smarter to do something else, because although
 what I suggested above fixes the {{{is_isomorphic}}} method, the
 {{{isomorphism}}} method still does not work.

 I am attaching a branch that changes the output of two auxiliary
 functions. When computing echelonized forms of 2d fans and when trying to
 find isomorphisms between fans, the coordinates now used aren't those of
 the ambient space anymore, but of a basis of the lattice.
 I'm not sure whether that's a smart thing to do, since there might be some
 arbitrariness in the choice of basis, but {{{FanMorphism}}} expects a
 matrix with {{{nrows}}} / {{{ncols}}} equal to the dimension of the
 lattice itself, not the dimension of the ambient space.

 What do you think? In any case, there are still some doctests missing.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=656fa89b8d9ab818c31c4b631a011727f340ea92
 656fa89]||{{{Isomorphisms between fans in sublattices}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/16012#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to