#15976: IntegerLattice class
-------------------------------------+-------------------------------------
Reporter: malb | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.3
Component: linear algebra | Resolution:
Keywords: | Merged in:
Authors: Martin Albrecht | Reviewers: Daniel Krenn
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/15976 | 4f6b44e9a1e3530409d4e9317e852a024093ee36
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by malb):
Replying to [comment:68 tscrim]:
> There's a couple of little things scattered throughout that I think
should be fixed before this gets merged. For example, in the `LLL`
definition, you have non-ascii characters where I think you should just
use the latex equivalents.
I disagree, using UTF-8 makes it a lot more readable and compact. Changing
it to TeX would be a step backward IMHO.
> The reference should be:
> {{{
> .. [Ref] blah on first line that needs continuing on
> the second line
> }}}
> (you have one space less and would be slightly surprised the doc builds
and has well-formatted output).
The documentation builds and - as far as I can tell - has well formated
output. If you'd prefer it to be aligned for consistency, I'm not
objecting.
> You could likely benefit from raw string formatting:
> {{{
> def foo():
> r"""
> The r in front makes this a "raw" string, so the backslash isn't an
> escape character. So you can do things like this: `\ZZ` and
`\alpha`.
> """
> pass
> }}}
I know this exists, but I find {{{`\\ZZ`}}} more straight-forward. I don't
think it needs to be changed, but if you prefer it differently, feel free
to go ahead.
> Bring stuff up to python3 compliance.
Python 3 compliance would be good :)
> I can go through and do these things tomorrow morning if you don't mind
the tweaks (and/or don't do it while I sleep `:P`).
Thanks.
--
Ticket URL: <http://trac.sagemath.org/ticket/15976#comment:70>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
