#15820: Implement sequences of bounded integers
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: algebra | Resolution:
Keywords: sequence bounded | Merged in:
integer | Reviewers:
Authors: Simon King | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5dc78c5f5f647bf95b98da916d7086fae539ffb8
u/SimonKing/ticket/15820 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hellooooooo Simon !
Sorry but I only began to read your code and now I should really go get
some
sleep. I paste my current notes here in the meantime, but I am a long way
from a
proper review job.
- bounded integer sequence, biseq. What about "integer sequence" ? All
integers
are "bounded" on a computer. Why add this "bounded" everywhere ? biseq
-> iseq
?
- `# Bitsize of "data"` --> bitsize of the whole sequence
- itembitsize --> necessarily a power of 2 ?
- `#cdef inline void dealloc_biseq(biseq_t S)` : why there if commented ?
- `list2biseq` (and others) -> `list_to_biseq` ?
- Comments on the function definitions --> Move it to the function's doc,
even
if it is their only content ?
- Could you write some doc, even if it is just one line, for cdef
functions ? A
bit like what we have for bitsets ? Something like
{{{
cdef biseq_t* allocate_biseq(size_t l, unsigned long int itemsize):
"""
Allocates a sequences of l integers stored on itemsize bits each.
"""
}}}
- I just figured out that you may have wanted to keep this list of
functions
above with short descriptions as an 'index' of what the file does. If
so, it
would be cool to do it in the html doc instead ! It is nice to have
documentation for C functions even if you have to do it by hand.. An
example
there :
http://www.sagemath.org/doc/reference/graphs/sage/graphs/base/static_sparse_graph.html
- list2biseq --> I wondered why this function wouldn't return a new biseq
buil
from a list instead of modifying an existing one.... Performance issue ?
Is
that critical in some cases ?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15820#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
