#5976: [with new patch; needs review] Add an Elliptic Curve Isogeny object
---------------------------+------------------------------------------------
Reporter: shumow | Owner: shumow
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-4.0.1
Component: number theory | Keywords: Elliptic Curves
---------------------------+------------------------------------------------
Comment(by shumow):
I have just posted a patch incorporating J. Cremona's suggestions, after
trac_5976_review.patch, apply trac_5976_review2.patch.
very explicitly, I have fixed the following things:
* In the doctests for the helper functions I think it would be better
to have direct rather than indirect doctests. For example in the tests at
lines 98-99 surely the fact that the twosides agree is a tautology since
the same code is used on both sides? And in compute_codomain_formula(),
why not put in a direct doctest. (In that function you do not really need
A1,A2,A3 and you can define a1,...,a6 in one line via
a1,a2,a3,a4,a6=E.ainvs(). Similarly elsewhere.) [fixed, in particular, all
private / helper functions now have doctests]
* compute_vw_kohel_even_deg1() does not use parameter a6. [fixed]
* l.225: incomplete sentence! [look for "missing text" in the source,
I put in at least 2] [fixed the two "missing texts", didn't see others.]
* The docstring for the isogeny method for elliptic curves should say
more: it should certainly detail the input parameters and give more
examples (possibly copied from the EllipticCurveIsogeny? documentation).
The point is the when someone E.<tab> and sees E.isogeny is available and
then types E.isogeny? they need to see how to use that function. [fixed]
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5976#comment:32>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
