#16303: 'make doc-clean' calls system-wide 'git', which may break 'make 
distclean'
----------------------------+----------------------------
       Reporter:  leif      |        Owner:
           Type:  defect    |       Status:  new
       Priority:  critical  |    Milestone:  sage-6.3
      Component:  build     |   Resolution:
       Keywords:            |    Merged in:
        Authors:            |    Reviewers:  Volker Braun
Report Upstream:  N/A       |  Work issues:
         Branch:            |       Commit:
   Dependencies:            |     Stopgaps:
----------------------------+----------------------------

Comment (by leif):

 Replying to [comment:4 jhpalmieri]:
 > I like the idea of adding a dash to the last line. That git command
 looks like a last resort anyway: the earlier part of the recipe deletes
 all of the autogenerated stuff.

 If that was true, why am I getting
 {{{
 cd src/doc && make clean
 Deleting generated docs...
 rm -rf en/reference/*/sage
 rm -rf en/reference/*/sagenb
 rm -rf en/reference/sage
 rm -rf en/reference/sagenb
 rm -rf output
 git clean -f -d .
 Removing common/static/
 Removing de/thematische_anleitungen/static/
 Removing de/thematische_anleitungen/templates/
 Removing de/tutorial/static/
 Removing de/tutorial/templates/
 Removing en/a_tour_of_sage/static/
 Removing en/a_tour_of_sage/templates/
 Removing en/bordeaux_2008/static/
 Removing en/bordeaux_2008/templates/
 Removing en/constructions/static/
 Removing en/constructions/templates/
 Removing en/developer/templates/
 Removing en/faq/static/
 Removing en/faq/templates/
 Removing en/installation/static/
 Removing en/installation/templates/
 Removing en/numerical_sage/static/
 Removing en/numerical_sage/templates/
 Removing en/prep/static/
 Removing en/prep/templates/
 Removing en/reference/algebras/static/
 Removing en/reference/algebras/templates/
 Removing en/reference/arithgroup/static/
 Removing en/reference/arithgroup/templates/
 Removing en/reference/calculus/static/
 Removing en/reference/calculus/templates/
 Removing en/reference/categories/static/
 Removing en/reference/categories/templates/
 Removing en/reference/coding/static/
 Removing en/reference/coding/templates/
 Removing en/reference/coercion/static/
 Removing en/reference/coercion/templates/
 Removing en/reference/combinat/static/
 Removing en/reference/combinat/templates/
 Removing en/reference/constants/static/
 Removing en/reference/constants/templates/
 Removing en/reference/cryptography/static/
 Removing en/reference/cryptography/templates/
 Removing en/reference/databases/static/
 Removing en/reference/databases/templates/
 Removing en/reference/dev/static/
 Removing en/reference/dev/templates/
 Removing en/reference/doctest/static/
 Removing en/reference/doctest/templates/
 Removing en/reference/dynamics/static/
 Removing en/reference/dynamics/templates/
 Removing en/reference/finance/static/
 Removing en/reference/finance/templates/
 Removing en/reference/finite_rings/static/
 Removing en/reference/finite_rings/templates/
 Removing en/reference/function_fields/static/
 Removing en/reference/function_fields/templates/
 Removing en/reference/functions/static/
 Removing en/reference/functions/templates/
 Removing en/reference/games/static/
 Removing en/reference/games/templates/
 Removing en/reference/geometry/static/
 Removing en/reference/geometry/templates/
 Removing en/reference/graphs/static/
 Removing en/reference/graphs/templates/
 Removing en/reference/groups/static/
 Removing en/reference/groups/templates/
 Removing en/reference/hecke/static/
 Removing en/reference/hecke/templates/
 Removing en/reference/history_and_license/static/
 Removing en/reference/history_and_license/templates/
 Removing en/reference/homology/static/
 Removing en/reference/homology/templates/
 Removing en/reference/interfaces/static/
 Removing en/reference/interfaces/templates/
 Removing en/reference/lfunctions/static/
 Removing en/reference/lfunctions/templates/
 Removing en/reference/libs/static/
 Removing en/reference/libs/templates/
 Removing en/reference/logic/static/
 Removing en/reference/logic/templates/
 Removing en/reference/matrices/static/
 Removing en/reference/matrices/templates/
 Removing en/reference/matroids/static/
 Removing en/reference/matroids/templates/
 Removing en/reference/misc/static/
 Removing en/reference/misc/templates/
 Removing en/reference/modabvar/static/
 Removing en/reference/modabvar/templates/
 Removing en/reference/modfrm/static/
 Removing en/reference/modfrm/templates/
 Removing en/reference/modmisc/static/
 Removing en/reference/modmisc/templates/
 Removing en/reference/modsym/static/
 Removing en/reference/modsym/templates/
 Removing en/reference/modules/static/
 Removing en/reference/modules/templates/
 Removing en/reference/monoids/static/
 Removing en/reference/monoids/templates/
 Removing en/reference/notebook/static/
 Removing en/reference/notebook/templates/
 Removing en/reference/number_fields/static/
 Removing en/reference/number_fields/templates/
 Removing en/reference/numerical/static/
 Removing en/reference/numerical/templates/
 Removing en/reference/padics/static/
 Removing en/reference/padics/templates/
 Removing en/reference/parallel/static/
 Removing en/reference/parallel/templates/
 Removing en/reference/plane_curves/static/
 Removing en/reference/plane_curves/templates/
 Removing en/reference/plot3d/static/
 Removing en/reference/plot3d/templates/
 Removing en/reference/plotting/static/
 Removing en/reference/plotting/templates/
 Removing en/reference/polynomial_rings/static/
 Removing en/reference/polynomial_rings/templates/
 Removing en/reference/power_series/static/
 Removing en/reference/power_series/templates/
 Removing en/reference/probability/static/
 Removing en/reference/probability/templates/
 Removing en/reference/quadratic_forms/static/
 Removing en/reference/quadratic_forms/templates/
 Removing en/reference/quat_algebras/static/
 Removing en/reference/quat_algebras/templates/
 Removing en/reference/quivers/static/
 Removing en/reference/quivers/templates/
 Removing en/reference/repl/static/
 Removing en/reference/repl/templates/
 Removing en/reference/riemannian_geometry/static/
 Removing en/reference/riemannian_geometry/templates/
 Removing en/reference/rings/static/
 Removing en/reference/rings/templates/
 Removing en/reference/rings_numerical/static/
 Removing en/reference/rings_numerical/templates/
 Removing en/reference/rings_standard/static/
 Removing en/reference/rings_standard/templates/
 Removing en/reference/sat/static/
 Removing en/reference/sat/templates/
 Removing en/reference/schemes/static/
 Removing en/reference/schemes/templates/
 Removing en/reference/semirings/static/
 Removing en/reference/semirings/templates/
 Removing en/reference/static/
 Removing en/reference/stats/static/
 Removing en/reference/stats/templates/
 Removing en/reference/structure/static/
 Removing en/reference/structure/templates/
 Removing en/reference/templates/
 Removing en/reference/tensor/static/
 Removing en/reference/tensor/templates/
 Removing en/thematic_tutorials/static/
 Removing en/thematic_tutorials/templates/
 Removing en/tutorial/static/
 Removing en/tutorial/templates/
 Removing fr/a_tour_of_sage/static/
 Removing fr/a_tour_of_sage/templates/
 Removing fr/tutorial/static/
 Removing fr/tutorial/templates/
 Removing pt/a_tour_of_sage/static/
 Removing pt/a_tour_of_sage/templates/
 Removing ru/tutorial/static/
 Removing ru/tutorial/templates/
 Removing tr/a_tour_of_sage/static/
 Removing tr/a_tour_of_sage/templates/
 }}}
 ?

 > [...] I'm not sure how else we'd get anything that git would need to
 clean up.

 I mean removing those (empty?) folders might not be necessary (I don't
 know), but certainly the `git clean` there isn't a nop.

--
Ticket URL: <http://trac.sagemath.org/ticket/16303#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to