#16353: A cached_function with selective memory
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.3
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
performance | Work issues:
Keywords: | Commit:
Authors: | 7eb8f900f1a143c6cc85b9382a365b57a9c42ecc
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/16353 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by kcrisman):
> I did sketch how to organize Nathan's original code already at
https://groups.google.com/d/msg/sage-devel/OPe5VJpBiB4/OswLwqsMJKcJ.
What I find interesting about this is the quote
> > No. The tests of the work_for_case_x function go to that function.
This ties
> > the tests much better to the implementation than what you currently
have.
> I agree with that and implemented it earlier but it was refused during a
review.
so maybe some of the problem is external to this particular ticket? Maybe
in the other review one could ask for a second opinion from elsewhere,
always a reasonable thing to do.
> designs.orthogonal_array doesn't return some kind of array
Probably that is the real problem. In the current stable branch,
{{{
def orthogonal_array(k,n,t=2,check=True):
r"""
Return an orthogonal array of parameters `k,n,t`.
}}}
And I don't see anywhere in the code, or doctested, that you should get a
boolean or an integer. This must be a recent thing (I do see it in
6.3.beta3) and I would definitely agree that was bad design. It seems
that #16286 and #15310 were the culprits, I have found it now. (Note to
Volker - all those git-induced commits made it very, very hard to track
down what should have been extremely straightforward in such a new file!
Oh well, I'll get there eventually.)
----
That doesn't mean one can't have a cache with selective memory, but maybe
we can disentangle that from the very strange decision made there.
--
Ticket URL: <http://trac.sagemath.org/ticket/16353#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
