#15316: Make gf2x respect SAGE_FAT_BINARY and use --libdir
-------------------------------------+-------------------------------------
       Reporter:  jpflori            |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  critical           |    Milestone:  sage-6.3
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:  spkg gf2x          |    Reviewers:  Jeroen Demeyer
        Authors:  Jean-Pierre Flori  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  a23168950a9901003604b85a765379d24ac63fb3
  u/jpflori/ticket/15316             |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by emassop):

 * status:  needs_review => needs_work


Comment:

 Replying to [comment:52 jpflori]:
 > Replying to [comment:50 jdemeyer]:
 > > Yes, the `!= xno` should be replaced by `= xyes` I guess.
 > That would also do the trick.

 Not quite: $gf2x_cv_cc_supports_sse2 can be "requires -msse2", and
 $gf2x_cv_cc_supports_pclmul can be "requires -mpclmul".

 Seems more sane to me to run CHECK_SSE2_SUPPORT and CHECK_PCLMUL_SUPPORT
 always, so that the case  where gf2x_cv_cc_supports_sse2/pclmul is
 undefined does not occur, with enable_sse2=no and enable_pclmul=no as
 appropriate.

--
Ticket URL: <http://trac.sagemath.org/ticket/15316#comment:58>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to