#16430: Small speedup for OA(None,p^c)
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16430 | 03c1f4515b266f11e905136d6bda9a9de126b322
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Okayyyyyyyyy... I fixed several things, as this ticket seems to be a
"small bugfixes" dictionary `:-P`
1) More explicit error messages in _check_pbd. This function will be
rewritten in Cython later anyway, but this way we will not forget the
error messages.
2) We can always build an `OA(1341,0)`, i.e. the empty list
3) There is always an `orthogonal_array(t,n,t=t)`. It is just the result
of `[k]^k`
4) I fixed the "undefined for `t<k` bug you mentionned, but I wondered if
there was a reason to have such an exception. I mean, if you want a
property to hold "for any t columns", it holds in particular when you have
<t columns doesn't it ? So I would vote for removing this exception. If
you agree with it I will add a commit, while in the updated branch the
problem is avoided without touching this line
5) I return an `OA(t,n,t)` directly to avoid calling
`is_orthogonal_array`. It is safe because the orthogonal array I return IS
an orthogonal array, and I do it because `is_orthogonal_array` does not
support t>2 yet. But then, those orthogonal arrays are the only ones we
can return with t>2.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16430#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
