#9439: hyperbolic geometry
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner: vdelecroix
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: geometry | Resolution:
Keywords: hyperbolic | Merged in:
geometry, Poincare disc, upper | Reviewers: Johan Bosman
half plane, Beltrami-Klein, | Work issues:
hyperboloid model, sd35 | Commit:
Authors: Vincent | fe22a753e12f7779c4ab70dd733a917915fa84f4
Delecroix, Martin Raum, Greg Laun | Stopgaps:
Report Upstream: N/A |
Branch: |
public/ticket/9439 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
I've made some convention fixes and cleanup. I also have the following
comments:
- I'm not completely sure the framework that is currently there shouldn't
be restructured as abstract base classes as you're not creating an army of
hyperbolic spaces, just one in each type with data from a "database".
Moreover there seems to be a lot of redundancy.
- I think too much is getting imported into the global namespace (ex.
`UHP`) which could have potential conflicts and in many ways is a strange
acronym. It would probably be better to have them located via
`HyperbolicSpace` (which would be a factory function or the base class
with a `__classcall__`) and/or a catalog import `hyperbolic_space`.
I will have to think more about the first one. The second should be done
at some point unless there is a very good argument otherwise IMO.
--
Ticket URL: <http://trac.sagemath.org/ticket/9439#comment:46>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
