#16521: Add is_perfect() for fields
-------------------------------------+-------------------------------------
       Reporter:  saraedum           |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  minor              |    Milestone:  sage-6.3
      Component:  categories         |   Resolution:
       Keywords:  sd59               |    Merged in:
        Authors:  Julian Rueth       |    Reviewers:  Martin Albrecht
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/saraedum/ticket/16521            |  a081f2f5827bcb378b3fa0895d074a25a74454e8
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by saraedum):

 * status:  needs_work => positive_review


Comment:

 Replying to [comment:5 vbraun]:
 > Do a "make doc-clean && make doc"
 > {{{
 > [function_] /mnt/SSD1/mod_buildslave/sage_git/build/local/lib/python2.7
 /site-packages/sage/rings/function_field/function_field.py:docstring of
 sage.rings.function_field.function_field:5: WARNING: Bullet list ends
 without a blank line; unexpected unindent.
 > [function_] /mnt/SSD1/mod_buildslave/sage_git/build/local/lib/python2.7
 /site-packages/sage/rings/function_field/function_field.py:docstring of
 sage.rings.function_field.function_field:15: ERROR: Inconsistent literal
 block quoting.
 > [function_] /mnt/SSD1/mod_buildslave/sage_git/build/local/lib/python2.7
 /site-packages/sage/rings/function_field/maps.py:docstring of
 sage.rings.function_field.maps:3: WARNING: Bullet list ends without a
 blank line; unexpected unindent.
 > }}}

 I can not reproduce this problem and also the patchbot does not see it.

 `WARNING: Bullet list ends without a blank line; unexpected unindent.`
 does not make sense to me in `function_field.py` since I did not
 add/modify a bullet list there.

 Therefore, I set this back to `positive_review`. I hope that I have not
 missed anything.

--
Ticket URL: <http://trac.sagemath.org/ticket/16521#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to