#16528: OA(9,120)
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16528 | 3487f093a5c6f8ee2f5454357276125a142c95d7
Dependencies: #16524 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_info
Comment:
Just a commented commit (at `u/vdelecroix/16528`)
Why if it is precomputed you do the extra check
{{{
for B in BIBD:
len_trace = sum(x in hyperoval for x in B)
assert len_trace == 0 or len_trace == 2
}}}
(commented in my commit)
I replaced the ugly `Matrix[x].dict().keys()` by
`M.nonzero_positions_in_row(x)`.
In two places it is not needed to build a list, Python iterator are useful
for that
{{{
- len_trace = len([x for x in B if x in hyperoval])
+ len_trace = sum(x in hyperoval for x in B)
- r = {v:i for i,v in enumerate([x for x in range(n) if x not in
hyperoval])}
+ r = {v:i for i,v in enumerate(x for x in range(n) if x not in
hyperoval)}
}}}
That's all before the positive review.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16528#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
