#16528: OA(9,120)
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers: Vincent Delecroix
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: | c80b7f464e197ad15ed239ef1246b197d12e4a69
u/vdelecroix/16528 | Stopgaps:
Dependencies: #16524 |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_info => positive_review
* commit: 3487f093a5c6f8ee2f5454357276125a142c95d7 =>
c80b7f464e197ad15ed239ef1246b197d12e4a69
* branch: u/ncohen/16528 => u/vdelecroix/16528
* reviewer: => Vincent Delecroix
Comment:
Yo !
> Why if it is precomputed you do the extra check
> {{{
> for B in BIBD:
> len_trace = sum(x in hyperoval for x in B)
> assert len_trace == 0 or len_trace == 2
> }}}
> (commented in my commit)
Because it costs nothing, and because, given that the constructions are
not always obvious, it is good to explain what it happening all along. It
works the same way if it is commented.
> I replaced the ugly `Matrix[x].dict().keys()` by
`M.nonzero_positions_in_row(x)`.
Thanks ! I did not know this function before you used it in another
ticket.
> In two places it is not needed to build a list, Python iterator are
useful for that
If you believe that it makes any difference ... `:-P`
> That's all before the positive review.
Okayyyyyy ! Thanks, then `:-)`
Nathann
P.S. : Something weird is happening. That's the last construction in
`needs_review` ! I will fix that as soon as I get Julian's next mail `;-)`
Nathann
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=c80b7f464e197ad15ed239ef1246b197d12e4a69
c80b7f4]||{{{trac #16528: review}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16528#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
