#16579: Tides interface
-------------------------------------+-------------------------------------
Reporter: mmarco | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.3
Component: interfaces | Resolution:
Keywords: sd59 | Merged in:
Authors: Miguel Marco | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mmarco/ticket/16579 | ebcf706d5514cb3a705bce2bdbc35dfdd5c2f3e9
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_info
Comment:
First quick pass
- What is an IVP?
- Please be more careful with the doc:
- symbollic -> symbolic
- desored -> desired
- paramters -> parameters
- why did you lazy import `NN`?
- as trigonometric functions are only used in `subexpressions_list` it
would be better to import them only inside the function.
- Are you sure that `subexpressions_list` must belong to this module?
- In the function `subexpressions_parameters` the extra argument
`parameters` is never tested.
- You should '''never''' use an empty list in the definition of a function
{{{
sage: def f(a=[]): return a
sage: a = f()
sage: a.append(18)
sage: f()
[18]
}}}
- why do you use `fast_callable`? There is no introspection directly from
the expression?
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16579#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
