#16579: Tides interface
-------------------------------------+-------------------------------------
       Reporter:  mmarco             |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-6.3
      Component:  interfaces         |   Resolution:
       Keywords:  sd59               |    Merged in:
        Authors:  Miguel Marco       |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/mmarco/ticket/16579              |  8902f6146662270b68fca4745284f0aa32f8818f
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by mmarco):

 - What is an IVP?
 An inital value problem. Clarified in the documentation now.

 - Please be more careful with the doc:
 checked.

 - why did you lazy import NN?
 sorry about that, at some point this code was in desolvers, that was
 automatically loaded and produced a circular dependency error at startup

 - as trigonometric functions are only used in subexpressions_list it would
 be better to import them only inside the function.
 Thanks, changed.

 - Are you sure that subexpressions_list must belong to this module?
 I wrote it for this specific purpose (in fact it was originally inside the
 code of the generator_.. functions), but i am open to suggestions. Where
 would it fit better?

 - In the function subexpressions_parameters the extra argument parameters
 is never tested.
 Added a doctest for that.

 - You should never use an empty list in the definition of a function
 ups, you are right, took care of that.

 - why do you use fast_callable? There is no introspection directly from
 the expression?
 fast_callable does the job of deciding the correct order for the
 operations to be properly executed. Doing that directly from the
 expression tree is possible (and maybe not hard), but also not trivial.

--
Ticket URL: <http://trac.sagemath.org/ticket/16579#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to