#15915: add discrete Gaussian samplers to Sage
-------------------------------------+-------------------------------------
Reporter: malb | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: statistics | Resolution:
Keywords: sd59 | Merged in:
Authors: Martin Albrecht | Reviewers: Julian Rueth
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/malb/t15915_discrete_gaussians | da3efcfb1bbb840f075e00ae8bc905944c9c2f81
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by malb):
* commit: 193923913f78b59d0fed598d50cf46ad4177c2ea =>
da3efcfb1bbb840f075e00ae8bc905944c9c2f81
* branch: u/saraedum/ticket/15915 => u/malb/t15915_discrete_gaussians
Comment:
Replying to [comment:35 saraedum]:
> A few questions (line numbers are all in the version I pushed):
>
> * Should it really be x-2 in line 518 of dgs_gauss.h?
It should read x-c, fixed.
> * What is the TODO in dgs_gauss_dp.c?
This was a left-over, removed.
> * `self->c_r = 0.0;` after an abort() in line 114 and 130 of
dgs_gaus_dp.c?
Removed.
> * What is "this B" in line 186 of discrete_gaussian_lattice.py?
self.B, fixed this.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=da3efcfb1bbb840f075e00ae8bc905944c9c2f81
da3efcf]||{{{fixed issues identified by Julian Rüth}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15915#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
