#15915: add discrete Gaussian samplers to Sage
-------------------------------------+-------------------------------------
Reporter: malb | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: statistics | Resolution:
Keywords: sd59 | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/malb/15915_discrete_gaussians | e6a80b20962e2945dfc72f23bd4747bcfab89a73
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by saraedum):
Some comments/questions:
In the `fmpz_poly` linkage: What is the except -2 good for? Do these flint
methods return -2 on error? Shouldn't you use sig_on()/sig_off() rather?
What is the reason for the following in `Polynomial_integer_dense_flint`?
{{{
- elif not isinstance(x, list):
- x = [x] # constant polynomials
+ else:
+ try:
+ x = list(x)
+ except TypeError:
+ x = [x] # constant polynomials
}}}
In `polynomial_quotient_ring.py`, why don't you use `r"""` so you can
write `\ZZ`? Also, there are now a lot of unicode characters; even though
you put an encoding in the header, my vim does not understand these
characters (strangely) and they also confused the patchbot.
I stopped reading at `dgs.h`. Would you mind relicensing this as GPLv2+?
Should such things not be in an SPKG? I wonder if the amount of
documentation is sufficient for including it directly in Sage and also if
anybody can really review this (I cannot review that part I'm afraid.)
--
Ticket URL: <http://trac.sagemath.org/ticket/15915#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
