#6185: [with patch, needs review] Add SBox -> CNF Conversion
--------------------------+-------------------------------------------------
 Reporter:  malb          |       Owner:  malb       
     Type:  enhancement   |      Status:  new        
 Priority:  major         |   Milestone:  sage-4.0.2 
Component:  cryptography  |    Keywords:  crypto, cnf
 Reviewer:                |      Author:             
   Merged:                |  
--------------------------+-------------------------------------------------

Comment(by ylchapuy):

 My 2 cents:

 * the complexity is 'n * 2**m' (instead of 'm * 2**n'):
 {{{
   for x in X:                        <-- 2^m
       for output_bit in output_bits: <-- n
 }}}
 * typos:
    * line 866: evaluate instead of evaulate
    * line 840: endianness instead of endianess

 * maybe add an exception if xi or yi has wrong size

 * maybe (but as you like) construct x's on the fly:
 {{{
   for e in xrange(2**m):
       x = self.to_bits(e)
 }}}
 otherwise seems good to me.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6185#comment:5>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to