#16608: Immediate fix for animations in notebook
-------------------------------------+-------------------------------------
Reporter: niles | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.3
Component: notebook | Resolution:
Keywords: notebook, animate | Merged in:
Authors: Niles Johnson | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/niles/ticket/16533-stopgap | 16cbd2d59b4b5bbb330668255345fc2d53f3afee
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by kcrisman):
> Of course, we could also merge your fix and then build all subsequent
modifications on that. After all, your fix is better than no fix at all,
and it looks like I might have to rebase most of my animation-related
changes anyway.
Martin, if the fix solves your problem and you agree with tests then let's
get this in. I can only test simple animations, I don't have ffmpeg
installed, but it does appear to work correctly and as I said the code
seems right. I'm not a big fan of making things rebase, as I find it very
tedious, but this is high enough priority that we should just fix it.
> This “display the animation” part of the promise is still broken in your
fix
True. Maybe just as a hack, one could always add `show_path=True` for
`EMBEDDED_MODE`... that might end up annoying. Maybe just when `if not
savefile and EMBEDDED_MODE` one could make
`savefile=graphics_filename(ext='.gif')` ? Would that work? Too hackish?
Also, Niles, you can actually test things with embedded mode... maybe we
should add that.
But we should do it soon!
--
Ticket URL: <http://trac.sagemath.org/ticket/16608#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
