#16608: Immediate fix for animations in notebook
-------------------------------------+-------------------------------------
Reporter: niles | Owner:
Type: defect | Status: positive_review
Priority: blocker | Milestone: sage-6.3
Component: notebook | Resolution:
Keywords: notebook, animate | Merged in:
Authors: Niles Johnson | Reviewers: Martin von Gagern
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/niles/ticket/16533-stopgap | 16cbd2d59b4b5bbb330668255345fc2d53f3afee
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by gagern):
* status: needs_review => positive_review
* reviewer: => Martin von Gagern
Comment:
Replying to [comment:7 kcrisman]:
> Martin, if the fix solves your problem and you agree with tests then
let's get this in.
Fine. Let's get this over with, and I'll have a look at rebases and proper
fixes after that.
> > This “display the animation” part of the promise is still broken in
your fix
> True. Maybe just as a hack, one could always add `show_path=True` for
`EMBEDDED_MODE`... that might end up annoying. Maybe just when `if not
savefile and EMBEDDED_MODE` one could make
`savefile=graphics_filename(ext='.gif')` ? Would that work? Too hackish?
Too hackish. Properly fixing this isn't that much harder. It would mean
doing the distinction between embedded mode and non-embedded mode for
''every'' occurrence of `tmp_filename`. Which is a lot of code duplication
unless you move that distinction ''into'' `graphics_filename`, which is
what #15515 is about. Maybe I can review that one soon, too, but don't
hold your breath on me since I've an important appointment coming up.
> Also, Niles, you can actually test things with embedded mode... maybe we
should add that.
Do you mean test suite? Can we run tests inside the notebook server
somehow? And see where things end up, what html gets generated and so on?
Or am I completely missing the point of what you meant?
In any case, changing tests at this point is probably a bad idea. Should
be a separate issue.
--
Ticket URL: <http://trac.sagemath.org/ticket/16608#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
