#16651: Buggy to_poly_solve option
-------------------------------------+-------------------------------------
       Reporter:  gagern             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  critical           |    Milestone:  sage-6.3
      Component:  symbolics          |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Volker Braun       |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vbraun/buggy_to_poly_solve       |  6fb6bee3a7ef1f692656f615f9361c9e52afeec1
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vbraun):

 Thanks, I switched to the while because the original code did add/remove
 stuff. But that was all wrong, and I forgot to switch it back.

 The main bug of the entire logic was that `X` was being iterated over and
 modified at the same time, so some solutions were skipped while other
 solutions were ran twice through Maxima. The first call to Maxima yielded
 a floating-point answer, and in the subsequent call Maxima converted the
 floating-point number to a rational.

 There was a similar bug when solve originally found no solution, causing
 maxima `to_poly_solve` to be called twice. I fixed that, too.

 The main doctest is the one you gave where some numerical solutions were
 incorrectly returned as rational.

--
Ticket URL: <http://trac.sagemath.org/ticket/16651#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to