#16598: New empty design classes for a better user interface and new
is_group_divisible_design Cython function
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner: ncohen
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16598 | e8251fb1c1f22a1b7c6a15bd8be9686cdd5f54e6
Dependencies: #16553 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_work => needs_review
Comment:
YOoooooooo !
> 1) There is a problem with your `relabel` method
Gloops. Sorry 'bout that `:-/`
> 2) For the string representation of divisible design, would not you
prefer `Group Divisible Design on 40 points of type 10^4` instead of the
current `Group Divisible Design on 40 points and type 10^4`
I don't care. I changed it,
> 3) This is very bad
> {{{
> round(sqrt(len(blocks)))
> }}}
> (i.e. it involves the symbolic ring).
Is it bad to involve the symbolic ring ? `O_o`
I imported sqrt from Python instead.
> 4) In `is_group_divisible_design` the parts `# Check that the groups
belong to [0,...,n-1]` and `# Check that the groups belong to [0,...,n-1]`
are very complicated. It is not clear to me that it would be the fastest
option (did you do some timings?). Would you mind having a more Pythonic
version:
> {{{
> # Check that the groups belong to [0,...,n-1]
> if any(i < 0 or i >= n for g in groups for i in g):
> # bad groups
> ...
> if any(i < 0 or i >= n for b in blocks for i in b):
> # bad blocks
> ...
> }}}
This code raises an exception when i cannot be turned into an integer. I
simplified it a bit, though.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16598#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
