#16685: power series reversion using flint
-------------------------------------+-------------------------------------
       Reporter:  jj                 |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-6.3
      Component:  number theory      |   Resolution:
       Keywords:  flint power        |    Merged in:
  series reversion                   |    Reviewers:  Jean-Pierre Flori
        Authors:  Jonas Jermann      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  c26bac1016c12b7ff440886c7bf69a18026a642e
  public/ticket/16685                |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by jpflori):

 * status:  needs_review => needs_work
 * reviewer:   => Jean-Pierre Flori


Comment:

 A few remarks:
 * this looks strange:
 {{{
 ...revert_series(5+1)
 }}}
 why not put 6 in there?
 * please beautify the docstring `f(self(x)) = ...` using sphinx syntax.
 * the variable name of the power series could be used in `and +1 or -1 as
 the coefficient for x^1`
 * please put `sig_on/sig_off` around the calls to the FLINT C function
 calls (unless you're sure it will always be super fast, but I fear it
 won't be the case for series with a large number of terms/polynomials of
 high degree).

--
Ticket URL: <http://trac.sagemath.org/ticket/16685#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to