#16706: Update IML to 1.0.4
-------------------------------------+-------------------------------------
       Reporter:  jpflori            |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-6.3
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:  iml spkg           |    Reviewers:
        Authors:  Jean-Pierre Flori  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  2380ff5e35628820fffe501ddba393e8702085d2
  u/jpflori/iml-1.0.4                |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by fbissey):

 Got it!
 {{{
                 if test "x${CBLAS_HEADER}" != "x/usr/include" -a
 "x${CBLAS_HEADER}" != "x/usr/local/include"; then
                         for CBLAS_LIBRARY in ${CBLAS_LIBRARY_PATH}
                         do
                                 if test "x${CBLAS_LIBRARY}" != "x/usr/lib"
 -a "x${CBLAS_LIBRARY}" != "x/usr/local/lib"; then
                                         CBLAS_CFLAGS="-I${CBLAS_HEADER}"
                                         CBLAS_LIBS="${CBLAS_LIBS}
 -L${CBLAS_LIBRARY}"
                                 fi
                         done
 }}}
 CBLAS_CFLAGS needs to be set outside of the test for CBLAS_LIBRARY. If you
 only have standard paths in CBLAS_LIBRARY_PATH, CBLAS_CFLAGS is never set.
 I would do
 {{{
                 if test "x${CBLAS_HEADER}" != "x/usr/include" -a
 "x${CBLAS_HEADER}" != "x/usr/local/include"; then
                         CBLAS_CFLAGS="-I${CBLAS_HEADER}"
                         for CBLAS_LIBRARY in ${CBLAS_LIBRARY_PATH}
                         do
                                 if test "x${CBLAS_LIBRARY}" != "x/usr/lib"
 -a "x${CBLAS_LIBRARY}" != "x/usr/local/lib"; then
                                         CBLAS_LIBS="${CBLAS_LIBS}
 -L${CBLAS_LIBRARY}"
                                 fi
                         done
 }}}
 instead. Nit-picky, should you do
 {{{
 CBLAS_LIBS="-L${CBLAS_LIBRARY} ${CBLAS_LIBS}"
 }}}
 instead of
 {{{
 CBLAS_LIBS="${CBLAS_LIBS} -L${CBLAS_LIBRARY}"
 }}}
 not sure if there are picky linker that would bother.

--
Ticket URL: <http://trac.sagemath.org/ticket/16706#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to