#16727: IncidenceStructure.__contains__
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/16727 | e7ef8c0e2b5f5ef36112428094faa8de2a32316c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dimpase):
Replying to [comment:10 ncohen]:
> > Good doctests should test the function as if it were a blackbox.
>
> Religion does not work on me.
It has nothing to do with religion, this is just common sense, sorry.
>
> > Unless you prefer bug-driven development model to the test-driven one
;-)
>
> I am not against doctests, I am against your spending my time on this. I
believe that this function is sufficiently doctested, and I already added
tests because you asked. If they don't satisfy you for some reason, I do
not mind it but you will have to write your own and add it to the branch.
I believe that I explained sufficiently clear that testing only corner
cases does not work, yet you added another corner case test, for a
complete uniform hypergraph is a corner case, AFAIK.
And I have elected to be a reviewer, sorry. It is my job to decide what a
sufficient doctest is, not yours.
Well, if you cannot add the doctests I ask for, I can surely do this too,
only then you will be spending my time on this, not the other way around.
--
Ticket URL: <http://trac.sagemath.org/ticket/16727#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
