#16727: IncidenceStructure.__contains__
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/16727       |  e7ef8c0e2b5f5ef36112428094faa8de2a32316c
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Yo !

 > I believe that I explained sufficiently clear that testing only corner
 cases does not work, yet you added another corner case test, for a
 complete uniform hypergraph is a corner case, AFAIK.

 A uniform hypergraph is a "corner case" in hypergraph theory. Not as an
 example of Python list. I mixed integers and strings, and order. That's
 how I tested non-corner cases that made sense from the point of view of
 what this function does. It is also a doctest of the bug I reported in
 this ticket's description.

 > And I have elected to be a reviewer, sorry. It is my job to decide what
 a sufficient doctest is, not yours.

 Indeed, but when you see that you cannot explain what you want without
 making lose the other guy's time because he apparently does not get it,
 you can save everybody by writing the 4 lines yourself.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/16727#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to