#15140: AbelianGroups should be in Groups().Commutative() /
Groups().Commutative().Finite()
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: group theory | Resolution:
Keywords: | Merged in:
Authors: Travis Scrimshaw | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/groups/abelian_groups_category-15140|
757c0449bb1dcc52ab36c11658d8ba653769ca78
Dependencies: #10963 #16725 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_info => needs_review
Comment:
Replying to [comment:8 ncohen]:
> 1) Is there any reason why AbelianGroup does not appear in
`groups.<tab>` ?
Probably because someone missed it when doing the initial groups catalog.
Add it to `groups.misc.<tab>` here?
> 2) When is the code from `Groups.ParentMethods.monoid_generators` being
used ? You removed a couple of lines as this case is handled by the new
`FiniteGroups.ParentMethods.monoid_generators`, but then the code of the
first method claims that it raises an exception when self is not a
`FiniteEnumeratedSet`. Couldn't this method be removed too ? I actually do
not understand in which situation that fonction worked without using the
"if/return" that you removed.
`Groups.ParentMethods.monoid_generators` is used for any parent in the
category of `Groups` that doesn't implement its own `monoid_generators`.
If a group is in `FiniteGroups`, which is what the `if` statement was
checking, then (with this change) it calls the
`FiniteGroups.ParentMethods.monoid_generators` instead (it's closer to the
front of the MRO). It's a cleaner design (and something I should've
realized on #16725).
--
Ticket URL: <http://trac.sagemath.org/ticket/15140#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
