#15140: AbelianGroups should be in Groups().Commutative() /
Groups().Commutative().Finite()
-------------------------------------+-------------------------------------
       Reporter:  nthiery            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  group theory       |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Travis Scrimshaw   |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/groups/abelian_groups_category-15140|  
757c0449bb1dcc52ab36c11658d8ba653769ca78
   Dependencies:  #10963 #16725      |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Travis Scrimshaw', 'oldvalue': ''}):

 * status:  new => needs_review
 * commit:   => 757c0449bb1dcc52ab36c11658d8ba653769ca78
 * dependencies:  #10963 => #10963 #16725
 * branch:   => public/groups/abelian_groups_category-15140
 * author:   => Travis Scrimshaw


Comment:

 I've added a general `semigroup_generators` for all monoids, which returns
 the monoid generators and the unit (and assuming finitely generated). I've
 also defined a `monoid_generators` for finite groups in `FiniteGroups`
 instead of an `if` statement as a followup to #16725.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=0791169b9da23d7f8321135bdedf7271f90f38dc
 0791169]||{{{Added monoid generators for general groups.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=e5cd7cc463e41cde71e16279b41155113400afb4
 e5cd7cc]||{{{Added try-except block for group_generators to fallback to
 monoid_generators.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c64a5fb9487a0d54da40acd2003b0a2930f06207
 c64a5fb]||{{{Added message for NotImplementedError for infinitely
 generated groups.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=796262d2ecb0d4aebc168e5107d5cd5ebb0d9d2d
 796262d]||{{{Changed behavior of general group_generators method.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=4606f0e6c3a0ce322d550ced4a022ac2fbca2b03
 4606f0e]||{{{Fixed category for abelian groups.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=2d58f4fc9b2a404458876d4e3167c894e2ab18ad
 2d58f4f]||{{{Implemented a general semigroup_generators() for
 monoids.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=757c0449bb1dcc52ab36c11658d8ba653769ca78
 757c044]||{{{Moved monoid_generators to a method for finite_groups.}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/15140#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to