#16261: Default behaviour of AdditiveAbelianGroup(a_tuple)
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: group theory | Resolution:
Keywords: | Merged in:
Authors: Nathann Cohen | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/groups/additive_abelian_groups_tuples-16261|
36cf5008dd7712178b5b96ef38b9eb8518c7ddfb
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
* branch: u/ncohen/16261 =>
public/groups/additive_abelian_groups_tuples-16261
* commit: 890c448ad9ea547feb778b5f8e69f6bbac452f1d =>
36cf5008dd7712178b5b96ef38b9eb8518c7ddfb
Comment:
Hey Nathann,
I gave the `short_repr` more functional-type and cleaner (IMO)
implementation. I've also made some lines shorter and made line breaks at
more logical positions.
As for finding the orders of the original cyclic groups in `short_repr`, I
think the current implementation is okay for now. You could make this data
into a (cached) method, but IDK if this is worthwhile or useful for
anyone. A "better" fix would be to pass this data from the factory
function to the class, but you should deal with handling old pickles which
don't (a priori) contain this part of the class's input.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=aa17e43fe1097a6d9e2ef504544a81bb78e92b1a
aa17e43]||{{{Merge branch 'u/ncohen/16261' of trac.sagemath.org:sage into
public/groups/additive_abelian_groups-16261}}}||
||[http://git.sagemath.org/sage.git/commit/?id=36cf5008dd7712178b5b96ef38b9eb8518c7ddfb
36cf500]||{{{Better IMO short_repr method and made some lines
shorter/logically line broken.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16261#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
