#16802: difference family database
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone:
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Vincent Delecroix | Work issues:
Report Upstream: N/A | Commit:
Branch: public/16802 | d8f8fef657006eef8ee4a5446d083a6cb45ae21f
Dependencies: #16757 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_work => needs_review
* commit: e8984623ba5c4b181971e0524ca47dbe9cc204fc =>
d8f8fef657006eef8ee4a5446d083a6cb45ae21f
* branch: u/vdelecroix/16802 => public/16802
Comment:
Thanks for the rebase.
Replying to [comment:4 ncohen]:
> Yooooooooooooooooooooooooooooo !!!!
>
> First review of this patch (it will be clearer after those points have
been solved):
>
> - The DF in the database: why add a 'S' in the *blocks* of short groups
?
removed
> - The database looks a bit messy as it is. Could you align some stuff,
like the ':' or the ',' so that one can actually read it in the code ?
> - The database should be indexed with `(v,k,l)` instead of
`((v1,v2,v3),k,l)`.
> - With a database indexed with `(v,k,l)` you can undo those
modifications
> {{{
> -if (v,k,l) in DF_constructions:
> +G_df = DF_from_database(v,k,l,short_blocks=short_blocks)
> +if G_df:
> }}}
done, done, done.
For the rest, some people defines difference families with short blocks
(as in the Handbook) and some people do not allow them (like in Stinson
for example). So you have to care about the two definitions.
About the functions {{{block_stabilizer, orbit_representatives,
partial_differences}}} it is used in basically two places:
{{{is_difference_family}}} and {{{BIBID_from_difference_family}}}. You can
not avoid them in the former. Nevertheless:
- I removed {{{partial_differences}}} as it was used in only one place
and is a two lines function
- I rewrote some of the doc
As you can see, the {{{is_difference_family}}} is '''very''' detailed and
it was very useful to debug the database from the Handbook.
I do not see the need of multiplicative Abelian group in difference
families...
Vincent
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=65182291358e6cc823dc912531188fe6d14f0403
6518229]||{{{trac #16802: database of difference family}}}||
||[http://git.sagemath.org/sage.git/commit/?id=d8f8fef657006eef8ee4a5446d083a6cb45ae21f
d8f8fef]||{{{trac #16802: review 1}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16802#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
