#16780: Brouwer's separable design construction of OA
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/16780       |  52c4fa0e328d0ccf666506d8a8b2d89ae528ccd3
   Dependencies:  #16863             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 In my last commit (at `public/16780`):
 - added in the doc: in case i) `x=0`, we construct a resolvable
 `OA(k-1,N)`.
 - the `l.extend([f(x) for x in R])` are replaced by `l.extend(f(x) for x
 in R)` (we win at least 2ms... incredible, isn't it?)
 - `Exception` -> `RuntimeError`
 - the size of a matrix is given as `nb_rows x nb_cols` and not the
 contrary

 I would not say that I carefully checked all constructions, but I am
 confident since there is a lot of doctest. I think it could go to positive
 review.

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/16780#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to