#16780: Brouwer's separable design construction of OA
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/16780 | 931a33fe5720312ec1b109e2a6d1de29472a8256
Dependencies: #16863 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello !
> - added in the doc: in case i) `x=0`, we construct a resolvable
`OA(k-1,N)`.
Good, good !
> - the `l.extend([f(x) for x in R])` are replaced by `l.extend(f(x) for x
in R)` (we win at least 2ms... incredible, isn't it?)
Perhaps even twice that. Crazy.
> - `Exception` -> `RuntimeError`
Good good !
> - the size of a matrix is given as `nb_rows x nb_cols` and not the
contrary
I object, but I have everybody against me. So I will not object aloud.
>
> I would not say that I carefully checked all constructions, but I am
confident since there is a lot of doctest. I think it could go to positive
review.
Well, each case is tested and the code cannot return anything wrong anyway
as all results are checked before that. Somehow while the design code is
always very tricky there is no risk to return anything wrong.
I added a small commit to repeat "parallel classes" in a sentence, but
short of this everything is cool, and it can go. Thank you very much for
this review !
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16780#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
