#16901: cythonized function in combinatorial designs must be interruptible
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.4
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers: Nathann Cohen
Authors: Vincent Delecroix | Work issues:
Report Upstream: N/A | Commit:
Branch: | 4917f8563795f8976910c7d798ae7909b3a0396d
u/vdelecroix/16901 | Stopgaps:
Dependencies: #16879 |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
Comment:
Yo !
> The exception is propagated with the return value `-1`, I think it is
cleaner to make it an int.
Oh right, right.
> Anyway, the choice `int/bint` is just a compiler instruction for Cython.
There is no gain of having it a `bint` type here since it is always used
in C code.
Of course, but there if there is no reason to change that into an 'int' it
was better to keep it. And that's a good reason to change it. Good to go !
> The purpose of the bint type is to mix well Python booleans with C ints.
One difference (that I learn few seconds ago) is in
> {{{
> def f(b):
> int x = b
> bint y = b
> }}}
> The first conversion will involves `b.__int__` while the second
`b.__nonzero__`.
I hate Python.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16901#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
