#16570: Animate example looks broken
-------------------------------------+-------------------------------------
Reporter: gagern | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Martin von Gagern | Reviewers: Jakob Kroeker
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/gagern/ticket/16570 | a5e766dcccea56a5af130dc4f7cde649997dc646
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by gagern):
* status: needs_work => needs_review
Comment:
Replying to [comment:17 jakobkroeker]:
> Otherwise ffmpeg 0.6.5. complains about the 'long' parameter argument.
This might be a different new(?) issue, since several universities have SL
installations. (SL packages are dated)
Sounds like a different issue, yes. We might have to implement some
version detection there. Will you file a ticket for this? According to the
[http://ffmpeg.org/archive.html FFmpeg News archive] that version dates
from January 2012.
> All fixed examples worked as expected. However, there are two other
> broken animate examples; would you mind to fix them in this ticket? (see
below)
I did so in the commit I just pushed.
> What also should be changed (maybe also in this ticket, since it is a
pretty small
> change), is storing the name of the temporary directory in variable
named 'dir'.
> 'dir' is a keyword/a method and should not be overwritten
Overwriting [https://docs.python.org/2/library/functions.html#dir the dir
builtin] within the tests causes no immediate harm. Only when users adapt
these tests and therefore loose access to the builtin, then we'd have some
impact. Nevertheless, I'll change the name to `td`.
I fixed the other plots you mentioned. In the case of `a*b`, the
"unfortunate" range might in fact help demonstrate how this operation
behaves in the presence of non-matching ranges, so I'd leave that as it
is. And the last unfortunate range has no impact on the issue being
demonstrated, so I'll leave that as well.
I hope you'll have time to give this a positive review, even though I took
quite long to react to your input.
--
Ticket URL: <http://trac.sagemath.org/ticket/16570#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
