#16892: Function to check if a poset containt a subposet isomorphic to another
poset
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  
u/jmantysalo/function_to_check_if_a_poset_containt_a_subposet_isomorphic_to_another_poset|
  87b585264681072a670c5b3e1da6cf5d5c9782ad
   Dependencies:  #16909             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Hello !

 A few other remarks:

 - Could you only import `uniq` where you need it and not in the module's
 head ?

 - The first line of doc in `isomorphic_subposets_iterator` is still right
 after the `"""`

 - The one-line descriptions that you added to the index at the top of the
 file are not correct (as far as I can tell, english is not my language):

 "Return an iterator over the subposets isomorphic to other poset" -> to
 another poset ? Or 'to a given poset' ?

 - Could you add an 'INPUT' section to your functions ?

 Thanks,

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/16892#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to