#17045: Poset directed_subset() doesn't check for 2. argument
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: needs_work
Priority: trivial | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/poset_directed_subset___doesn_t_check_for_2__argument|
37af4841c07479f7b628f3560f745f81b6858eca
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Hello again !
Two comments:
1) I'm sorry to say that if you write `raise ValueError, message` the same
guys who complained about your "x <> y" last time will come and tell you
that it is not "PEP-<whatever>". Could you change it into `raise
ValueError("message")` ?
2) I do not believe that you need to modify `finite_poset` at all. Indeed,
one function calls the other, so if there is anything wrong with respect
to `direction` an exception will be raised anyway. What do you think ?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17045#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
