#17045: Poset directed_subset() doesn't check for 2. argument
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: needs_review
Priority: trivial | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/poset_directed_subset___doesn_t_check_for_2__argument|
b2ad1980a0fc795728b0781a7270f8e0b26f04d9
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jmantysalo):
* status: needs_work => needs_review
Comment:
Replying to [comment:9 ncohen]:
> 1) I'm sorry to say that if you write `raise ValueError, message` the
same guys who complained about your "x <> y" last time will come and tell
you that it is not "PEP-<whatever>". Could you change it into `raise
ValueError("message")` ?
Done this. Good to obey PEP-rules, nothing to be sorry about.
> 2) I do not believe that you need to modify `finite_poset` at all.
Indeed, one function calls the other, so if there is anything wrong with
respect to `direction` an exception will be raised anyway. What do you
think ?
I don't like the idea. `directed_subsets()` return a function. Hence error
message would be seen only after using it.
--
Ticket URL: <http://trac.sagemath.org/ticket/17045#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
