#17030: Knot Theory as a part of GSoC 2014.
-------------------------------------+-------------------------------------
       Reporter:  amitjamadagni      |        Owner:  amitjamadagni
           Type:  task               |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebraic          |   Resolution:
  topology                           |    Merged in:
       Keywords:                     |    Reviewers:  Miguel Marco
        Authors:  Amit Jamadagni,    |  Work issues:
  Miguel Marco                       |       Commit:
Report Upstream:  N/A                |  c020d916536244a736c6a2feb6665f49f31e0c6a
         Branch:                     |     Stopgaps:
  u/amitjamadagni/ticket/17030       |
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by amitjamadagni):

 Replying to [comment:37 vdelecroix]:
 > Replying to [comment:36 amitjamadagni]:
 > > Replying to [comment:35 vdelecroix]:
 > > > Hello,
 > > >
 > > > The logic of every if/else is completely crazy. Rewriting the
 `__init__` properly takes only half of the preceding implementation: see
 my commit at `u/vdelecroix/17030`. The code needs a lot of polishing. I
 did not dig in the details but it is clearly hard to read!
 > > >
 > > > Vincent
 > >
 > > I have browsed through the commit, data can also be a PD code when its
 length is 2 it is not always oriented gauss code.
 >
 > Yes and this is fine. From my commit:
 > {{{
 > +            if len(data) != 2 or not all(isinstance(i,list) for i in
 data[0]):
 > +                # here we expect a PD code
 > }}}
 > Which mean that you expect a PD code if either `len(data) != 2` '''or'''
 if any element of `data[0]` is not a list.
 >
 > Vincent

 Yeah ! I get it.

--
Ticket URL: <http://trac.sagemath.org/ticket/17030#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to