#17051: PentagonPoset and DiamondPoset, default argument for facade
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/strange_bug_in_poset_show__|
afbad02bdbcbf9bbee31493715d42d8bec46e2d6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello !
I added a small commit on top of yours. What it does :
1) Remove the `"` in the first line of doc of the `PentagonPoset`
constructor.
2) Improve the doc of the `facade` keyword
3) Bring the former doctest back. The point is that doctests are not only
useful to the users, but also to test our own code. I can't tell you how
many bugs are avoided just because there is always a doctest somewhere
that tests the corner case you did not think about. If we ever change the
data structure of Posets, do anything in the graphs backends, those
doctests are the only way we have to make sure everything is holding
together.
4) Changing the default value of facade was breaking doctests in another
file, so I updated them. In order to check the doctests use {{{sage -b &&
sage -tp <num_of_cpu> -l file_or_directory}}}
I will also create a ticket to ask Nicolas to write some documentation
about `Facade`, because right now there is none to find.
Set this ticket to `positive_review` if you agree with the changes.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17051#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
