#17121: LatticePoset: Add meet_irreducibles, faster is_distributive
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__add_meet_irreducibles__faster_is_distributive|
0ee134c54632d9950ac65d9ce47e54c0fab0e483
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
* reviewer: => Nathann Cohen
Comment:
Hello !
1) `meet_irreducibles`: you write `len(self.upper_covers())` which calls
`upper_covers_iterator` which iterates over all out-neighbors of a vertex
of the !HasseDiagram before relabelling them as !Poset elements. Why ? All
you want to do is check that the outdegree of those points if 1. You could
work on the diagram directly.
2) Please add the new functions to the index.
3) You cannot use `$` for latex code there. Use {{{`}}} instead. In order
to check that the doc compiles correctly run `sage -b && sage -docbuild
reference/combinat html` and look at the html files produced.
4) Use {{{()}}} instead of {{{\}}} to wrap code on multiple lines.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17121#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
