#17121: LatticePoset: Add meet_irreducibles, faster is_distributive
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__add_meet_irreducibles__faster_is_distributive|
b3e1bcad805e3cff946ee95bc225534a583ea248
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
> 2: There is no index where to add... So, more work to poset
documentation project.
Oh, no index for lattices. Right, sorry for my remark !
> As of 1, I did not do that for now; this is direct copy from
`join_`-counterparts. Point 4 is done, but long line of `==` is still
quite hard to read.
As you wish. Remember that there is some time there to save if you have
time problems later on.
> Also this same time I removed totally unused argument from
`cover_relations`. Is this OK to do in ticket title saying nothing about
it?
I don't mind. It will depend on the reviewers, though.
I will run all tests on a machine to check that removing this keyword does
not break anything somewhere.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17121#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
