#14019: equality is broken for Posets
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:  sage-combinat
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:  posets             |    Merged in:
        Authors:  Travis Scrimshaw,  |    Reviewers:  Travis Scrimshaw,
  Anne Schilling                     |  Anne Schilling
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/combinat/poset/fix_equality-14019|  
e677d31fa4e40822bcd00c509dd1ca94ed6de52d
   Dependencies:  #17059             |     Stopgaps:  #14185
-------------------------------------+-------------------------------------

Comment (by nthiery):

 Replying to [comment:93 git]:
 > Branch pushed to git repo; I updated commit sha1. New commits:
 >
 
||[http://git.sagemath.org/sage.git/commit/?id=e677d31fa4e40822bcd00c509dd1ca94ed6de52d
 e677d31]||{{{trac #14019: rename _linear_extension to
 _carries_linear_extension}}}||

 Thanks so much everyone for your work on this! Big kuddos to Anne and
 Travis for taking the lead!

 I read the discussion, and the decisions taken make sense to me. I still
 need to have a look at the code, but what I had seen in an earlier version
 Anne had pointed me too was looking good, so feel free to proceed anyway.

 Just one thing: I would prefer {{{_with_linear_extension rather}}} than
 {{{_carries_linear_extensions}}} since we already use this convention in
 our "WithBasis" and friends. I can do this change if you wish.

--
Ticket URL: <http://trac.sagemath.org/ticket/14019#comment:94>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to