#16004: Update notebook to utilize pure javascript JSmol for default live 3-D
-------------------------------------------------+-------------------------
Reporter: gutow | Owner: gutow
Type: enhancement | Status:
Priority: major | needs_review
Component: notebook | Milestone: sage-6.4
Keywords: Jmol 3D 3-D | Resolution:
Authors: Jonathan Gutow, Volker Braun | Merged in:
Report Upstream: Reported upstream. Developers | Reviewers:
acknowledge bug. | Work issues:
Branch: | Commit:
Dependencies: #17020 | Stopgaps:
-------------------------------------------------+-------------------------
Comment (by kcrisman):
The patches look fine (still need to test, trying to do that before
lunch!). A few comments/questions:
* I don't like how you reorganized base.html, because it's harder to read
the properties of the elements now.
* I like your catch of the `gettext` for Typeset, assuming that is indeed
translated in the localizations (it's not in message.pot, but that's
probably ok).
* You also removed a near there as well, and didn't put one in for
the Java enabling. Maybe that should stay.
* {{{onchange="3D_use_java_check(this.checked);"}}} looks nice, except
there is no such function in `sagenb/data/sage/js/notebook_lib.js `,
unlike for {{{pretty_print_check}}} and {{{live_3D_check}}}. Does it need
to be added there? If not and things still work, then that line should be
removed.
--
Ticket URL: <http://trac.sagemath.org/ticket/16004#comment:88>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
